clang-tidy: Apply modernize-avoid-c-arrays everywhere #6564
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The most recent change: TripleOscillator.cpp:314:3
+ Fix compilation errors
|
Might revert the changes made in |
sakertooth
force-pushed
the
modernize-avoid-c-arrays
branch
from
682e47d to
ed16818
Compare
Meant to fix the MSVC error where it was doing "voices.data()" when "voices" was not a std::vector Not sure if we need this or not, but the code becomes simpler without it.
This class should probably get a more general rework in the future.
messmerd
reviewed
Nov 9, 2022
messmerd
reviewed
Nov 9, 2022
DomClark
reviewed
Nov 9, 2022
…ialog.cpp Co-authored-by: Dominic Clark <[email protected]>
Co-authored-by: Dominic Clark <[email protected]>
…AudioFileFlac::writeBuffer for buf
…tions.cpp, and PianoRoll.cpp
…mentFunctions.cpp, and PianoRoll.cpp" This reverts commit 6e16b93. The previous commit resulted in compiler errors.
DomClark
reviewed
Dec 16, 2022
DomClark
reviewed
Dec 20, 2022
DomClark
reviewed
Dec 20, 2022
+ Rename typeDescStruct to TypeDescStruct + Make s_types const
DomClark
approved these changes
Dec 21, 2022
PhysSong
reviewed
Dec 29, 2022
Co-authored-by: Hyunjin Song <[email protected]>
PhysSong
approved these changes
Dec 29, 2022
56 tasks
sakertooth
added a commit
to sakertooth/lmms
that referenced
this pull request
May 30, 2023
Co-authored-by: Dominic Clark <[email protected]> Co-authored-by: Hyunjin Song <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This clang-tidy warns against using C-arrays and suggests using either an
std::arrayorstd::vector. Since the fix-its aren't supported for this check, all of these changes were done manually. Some C-style arrays were skipped as they made the code more verbose with no real benefit.